Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response type: Fix deadlock on scenarios with SynchronizationContext for remaining Response.ResourceType #1437

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Response type: Fix deadlock on scenarios with SynchronizationContext for remaining Response.ResourceType #1437

merged 2 commits into from
Apr 29, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Apr 27, 2020 •
edited
Loading

Pull Request Template

Description

This is a continuation of PR #1401 to fix all the remaining types.

The UserResponse.Database is returning UserCore instead of the correct UserInlineCore. To fix this issue the type was converted to inheritance instead of composition.

Composition created a circle reference where UserInlineCore needed UserCore for the actual implementation, but UserCore needed the UserInlineCore for the response creation.

Current model

public abstract User
internal UserCore : User
internal UserInlineCore : User

New model

public abstract User
internal UserCore : User
internal UserInlineCore : UserCore

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@j82w j82w self-assigned this Apr 27, 2020
@j82w j82w requested a review from sboshra as a code owner April 29, 2020 15:30
@j82w j82w merged commit 1312758 into master Apr 29, 2020
@j82w j82w deleted the users/jawilley/bug/responseType branch April 29, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@ealsur ealsur ealsur approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees

@j82w j82w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j82w @ealsur @kirankumarkolli